Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canvas.controls.debug.eventMode should be "none" to avoid debugging visualization breaking interactivity for the rest of the canvas. #9072

Closed
1 of 6 tasks
dev7355608 opened this issue Mar 16, 2023 · 1 comment
Assignees
Labels
bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. ux Issues focused on user experience improvements

Comments

@dev7355608
Copy link

What happened?

Point source polygon visualization prevents interaction with the canvas.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

.

What core version are you reporting this for?

Version 11 Prototype 2 (build 293)

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@dev7355608 dev7355608 added the bug Functionality which is not working as intended label Mar 16, 2023
@aaclayton aaclayton added ux Issues focused on user experience improvements canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. labels Mar 18, 2023
@aaclayton aaclayton self-assigned this Mar 22, 2023
@aaclayton aaclayton changed the title canvas.controls.debug.eventMode should be "none" canvas.controls.debug.eventMode should be "none" to avoid debugging visualization breaking interactivity for the rest of the canvas. Mar 22, 2023
@aaclayton
Copy link
Contributor

It's really annoying that the new PIXI behavior is that eventMode = "auto" by default in v7. I really feel that eventMode should be "none" by default and interactivity events should be opt-in. It is annoying to have to do code like:

    /**
     * A container of cursor interaction elements.
     * Contains cursors, rulers, interaction rectangles, and pings
     * @type {PIXI.Container}
     */
    this.cursors = this.addChild(new PIXI.Container());
    this.cursors.eventMode = "none";

    /**
     * Ruler tools, one per connected user
     * @type {PIXI.Container}
     */
    this.rulers = this.addChild(new PIXI.Container());
    this.rulers.eventMode = "none";

    /**
     * A graphics instance used for drawing debugging visualization
     * @type {PIXI.Graphics}
     */
    this.debug = this.addChild(new PIXI.Graphics());
    this.debug.eventMode = "none";

It would be much better to assign eventMode to a non-none value when you activate event listeners.

Maybe I will try and push this as a suggestion upstream to PIXI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. ux Issues focused on user experience improvements
Projects
Status: Done
Development

No branches or pull requests

2 participants