Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ActiveEffectConfig#title override now that the ActiveEffect document uses the name field like other document types. #9118

Closed
anathemamask opened this issue Mar 27, 2023 · 0 comments
Closed

Remove the ActiveEffectConfig#title override now that the ActiveEffect document uses the name field like other document types. #9118

anathemamask opened this issue Mar 27, 2023 · 0 comments
Assignees
@aaclayton
Labels
active-effects Issues related to Active Effects bug Functionality which is not working as intended i18n Localization and Internationalization Issues
Milestone
Version 11 - API ...

Comments

@anathemamask
Copy link
Collaborator

From @Huepfklotz#1353

ALL MODULES DISABLED? (true/false)
OS, Hosting, Browser (if applicable):
Short Description of bug: ActiveEffectConfig uses deprecated "label" in title getter
Simple steps to reproduce the bug: Open any active effect or look at get title() of ActiveEffectConfig in foundry.js
Screenshots and/or console errors:
image
@anathemamask anathemamask added bug Functionality which is not working as intended i18n Localization and Internationalization Issues active-effects Issues related to Active Effects labels Mar 27, 2023
@aaclayton aaclayton self-assigned this Mar 27, 2023
@aaclayton aaclayton changed the title ActiveEfectConfig has incorrect title due to deprecated label object Remove the ActiveEffectConfig#title override now that the ActiveEffect document uses the name field like other document types. Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaclayton aaclayton

Labels
active-effects Issues related to Active Effects bug Functionality which is not working as intended i18n Localization and Internationalization Issues
Projects
Foundry VTT - Version 11
Status: Done
Milestone
Version 11 - API Development 2
Development

No branches or pull requests
2 participants
@aaclayton @anathemamask