Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and improve the logic used to manage Token animation by taking advantage of the new TokenMesh data structure. #9172

Closed
aaclayton opened this issue Apr 6, 2023 · 0 comments
Assignees
Labels
breaking Issues which cause breaking changes to the API canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. tokens Issues related to Tokens and their appearance

Comments

@aaclayton
Copy link
Contributor

There is no meaningful API change for handling Token animation that results from this change, but there is one minor change which is technically breaking if this method was being used by an external package.

Token#getDisplayAttributes has been moved to TokenMesh#getDisplayAttributes, so if you were previously calling token.getDisplayAttributes() you now need to call token.mesh.getDisplayAttributes(). It is not intended that this function be used by external code though, so if you are using this function you may wish to consider if it is necessary to do so at all.

@aaclayton aaclayton added tokens Issues related to Tokens and their appearance breaking Issues which cause breaking changes to the API canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. labels Apr 6, 2023
@aaclayton aaclayton self-assigned this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issues which cause breaking changes to the API canvas Issues related to the PIXI canvas, rendering, and other WebGL functions. tokens Issues related to Tokens and their appearance
Projects
Status: Done
Development

No branches or pull requests

1 participant