Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling combatant visibility also hides it from the GM #9216

Closed
Fyorl opened this issue Apr 17, 2023 · 1 comment
Closed

Toggling combatant visibility also hides it from the GM #9216

Fyorl opened this issue Apr 17, 2023 · 1 comment
Assignees
Labels
bug Functionality which is not working as intended combat Issues related to Combat and the Combat Tracker ui Issues focused on user interface improvements

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Apr 17, 2023

Originally reported by Huepfklotz#1353 https://discord.com/channels/170995199584108546/1065764070680186930/1096726561027276900

Short Description of bug: Toggle visibility now completly hides the actor in the combat tracker even for the gm. This works in the dnd5e system because it has a css fix. But in any other system this is missing (see attached images). The css should probably go to the foundry css.
Simple steps to reproduce the bug:
Use a system which is not DND5E. Toggle the visibility for one actor in the combat tracker. Actor completely disappears without any good way to get it back.
Screenshots and/or console errors:

image

image

@Fyorl Fyorl added bug Functionality which is not working as intended ui Issues focused on user interface improvements combat Issues related to Combat and the Combat Tracker labels Apr 17, 2023
@Fyorl Fyorl added this to the Version 11 - Testing 1 milestone Apr 17, 2023
@Fyorl Fyorl self-assigned this Apr 19, 2023
@Fyorl Fyorl closed this as completed Apr 20, 2023
@Fyorl
Copy link
Contributor Author

Fyorl commented Apr 20, 2023

There is a fix for this in v11 that should catch most cases. When I was testing this with the DSA system specifically, I did notice that it didn't have the .combat-sidebar class on the #combat tab however, which will need to be re-added for this fix to work, or the system will need to provide its own CSS rule here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended combat Issues related to Combat and the Combat Tracker ui Issues focused on user interface improvements
Projects
Status: Done
Development

No branches or pull requests

1 participant