Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pack folders which do not themselves contain packs are skipped in the folder hierarchy #9390

Closed
2 of 6 tasks
admiralnlson opened this issue May 14, 2023 · 0 comments
Closed
2 of 6 tasks
Assignees
Labels
bug Functionality which is not working as intended compendium Issues related to Compendium packs

Comments

@admiralnlson
Copy link

admiralnlson commented May 14, 2023

What happened?

Pack folders which do not themselves contain packs are skipped in the folder hierarchy introduced with feature #9033.


The following Manifest configuration works as expected:

  "packFolders": [
    {
      "name": "Castle Falkenstein - Lorebooks",
      "sorting": "m",
      "packs": [
        "spells-1",
        "spells-2",
        "spells-3"
      ]
    },
    {
      "name": "Castle Falkenstein - Other",
      "sorting": "m",
      "packs": [
        "abilities-corebook",
        "weapons"
      ]
    }
  ],

=> It creates 2 folders called "Castle Falkenstein - Lorebooks" and "Castle Falkenstein - Other" => OK

But this one doesn't:

  "packFolders": [
    {
      "name": "Castle Falkenstein", 
      "sorting": "m",
      "folders": [
        {
          "name": "Lorebooks",
          "sorting": "m",
          "packs": [
            "spells-1",
            "spells-2",
            "spells-3"
          ]
        },
        {
          "name": "Other",
          "sorting": "m",
          "packs": [
            "abilities-corebook",
            "weapons"
          ]
        }
      ]
    }
  ],

It creates 2 folders called "Lorebooks" and "Other" at root level, skipping the "Castle Falksenstein" intermediate parent entirely => KO.

I tried adding an explicit empty packs array (as opposed to leaving it undefined) to the parent object like so:

      "packs": [],

but the outcome is the same. The parent folder was yet again skipped.

The only way for the folder hierarchy to be generated as expected is to make sure all folders at all levels contain at least one pack, which I believe should not be a requirement.

Please allow empty folders / folder levels also.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

see example above

What core version are you reporting this for?

11.297

Relevant log output

I don't believe there is anything about it in the console.

Bug Checklist

  • The issue occurs while all Modules are disabled
@admiralnlson admiralnlson added the bug Functionality which is not working as intended label May 14, 2023
@admiralnlson admiralnlson changed the title packFolders[i].folders not working as expected pack folders which do not themselves contain packs are skipped in the folder hierarchy May 14, 2023
@cswendrowski cswendrowski self-assigned this May 15, 2023
@cswendrowski cswendrowski added this to the Version 11 - Testing 3 milestone May 15, 2023
@cswendrowski cswendrowski added the compendium Issues related to Compendium packs label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended compendium Issues related to Compendium packs
Projects
Status: Done
Development

No branches or pull requests

2 participants