Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenConfig does not retrieve derived attributes for non-DataModel systems #9472

Closed
Fyorl opened this issue May 25, 2023 · 2 comments
Closed
Assignees
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended tokens Issues related to Tokens and their appearance

Comments

@Fyorl
Copy link
Contributor

Fyorl commented May 25, 2023

We moved to the model in #8726 for systems that use DataModels but should preserve the existing functionality for systems that don't, since it doesn't require any special toObject(false) behaviour.

@Fyorl Fyorl added bug Functionality which is not working as intended tokens Issues related to Tokens and their appearance api Issues related to the API used by Mod Devs labels May 25, 2023
@Fyorl Fyorl added this to the V11 - Stable Maintenance milestone May 25, 2023
@DJ4ddi
Copy link

DJ4ddi commented May 29, 2023

Just to clarify, can this cause resource attributes to be read as single values instead of bars (as described in #8907)?

@aaclayton
Copy link
Contributor

Yes, I believe it would have that side effect. The fix we would apply here should correct that issue, but @Fyorl can verify as part of what we merge in.

@Fyorl Fyorl self-assigned this May 30, 2023
@Fyorl Fyorl closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended tokens Issues related to Tokens and their appearance
Projects
Status: Done
Development

No branches or pull requests

3 participants