Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Encounter Title on the Combat Encounters tab #9515

Closed
mclemente opened this issue May 29, 2023 · 1 comment
Closed

Improve the Encounter Title on the Combat Encounters tab #9515

mclemente opened this issue May 29, 2023 · 1 comment
Assignees
Labels
i18n Localization and Internationalization Issues

Comments

@mclemente
Copy link

User Experience

TL;DR: Consider renaming "No Active Encounters" to "No Encounters" and change .combat-sidebar .combat-tracker-header div.encounter-controls h3's flex to 2.

Prints are on SWADE system.

The Encounter Title's "No Active Encounter" wraps up to a 3rd line on Portuguese.
image
Even if we were to use another a smaller word, it would still wrap to the 2nd line like in English.

Here's the "Not Started" translation (same things happens in English).
image

I think it would look better if the text didn't wrap and looked like how it looks when combat is on ("Round 1").

Here is how it would look like with flex: 2:
image
And here is how "No Active Encounters" would look if it dropped the "active":
image

@aaclayton aaclayton added the i18n Localization and Internationalization Issues label May 29, 2023
@aaclayton aaclayton added this to the V11 - Stable Maintenance milestone May 29, 2023
@aaclayton
Copy link
Contributor

Agree it should be just "No Encounters" instead of "No Active Encounters" as this would be more precise. We can look at the flexrow spacing while we're at it.

@Feu-Secret Feu-Secret self-assigned this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Localization and Internationalization Issues
Projects
Status: Done
Development

No branches or pull requests

3 participants