[alchemist] calculated splash

[milkyw4i]

Alchemist's Class Feat "Calculated Splash" is not incorporated into damage calculations.
Class feat reads:
You have calculated all the angles to maximize a bomb’s splash. When you throw an alchemical bomb with the splash trait, you can cause the bomb to deal splash damage equal to your Intelligence modifier (minimum 0) instead of the normal amount.

Likely, this also affects the Class Feat "Expanded Splash":
The particularly volatile compounds that you brew into your bombs result in them creating especially large and powerful explosions. When you throw an alchemical bomb that has the splash trait, you can add your Intelligence modifier to the bomb’s usual splash damage, and it deals splash damage to every creature within 10 feet of the target.

Please fix :-)

[sorrythatuserbla]

Expanded splash is trivial to fix by changing

to

But what about calculated splash?

Is it possible to overwrite the splash part with something like kh(@actor.abilities.int.mod, current_splash) ?

[milkyw4i]

yeah, it would appear that expanded splash applies to damage, not to splash damage, fixing this, would allow fixing calculated splash as well.
In Pseudocode:

splash_damage = item.splash_damage
if actor has calculated splash feat
splash_damage = actor.intelligence_modifier
if actor has expanded splash feat
splash_damage = item.splash_damage + actor.intelligence_modifier

[KSops]

Splash seems to be in a pseudo-existent state in the codebase. There's an explicit splash damage portion in the data entries and it gets converted into a modifier with damageCategory splash but the enumerated types in damageCategory doesnt include splash. Furthermore, a few months ago the ability to set damage category was removed from the flat modifier rules element so it's difficult to express now. It was removed in favor of a precision checkbox.

I can only assume the main devs have a plan for addressing it later so I'm leaving this issue alone for now.

[KSops]

Related/duplicate: #1875