Formatting issues in 1.1.0 in Foundry (system: The Dark Eye)

[cswendrowski]

In GitLab by @Fulla3 on Sep 30, 2021, 12:27

After updating to the new version (yeah, the module is not dead! :-)), I started to re-sync my articles, and I've been experiencing some formatting issues. The problem occurs as soon as I edit an entry within Foundry (I wanted to get rid of spoilers, as the spoiler tags from World Anvil don't transfer and spoilers just show up as regular text).

Character entry pre-editing:

Character entry after I edited something in the main character description text (not anywhere close to the now messed up formatting):

Note how from "date of birth" forward, everything appears as one single block of text.

Formatting issues continue in the other sections as well as soon as I edit anywhere - like when I edit something in the family section here to remove the spoiler:

It messes up this section here (religion etc.) as well as the formatting of the date of birth, height etc. section further up in the entry (the the screenshot above).

[cswendrowski]

Thanks for the issue report. I'll work with @adrien.schiehle to understand how the 1.1.0 changes impact the editor markup here.

[cswendrowski]

In GitLab by @Fulla3 on Sep 30, 2021, 12:57

Thank you so much for further developing this module!

[cswendrowski]

In GitLab by @adrien.schiehle on Sep 30, 2021, 14:28

Hello, I managed to reproduce it.

The problem comes from the behavior of the editor when he finds data like that :

<dt>General Details</dt>
<dd>A top sidebar</dd>

It doesn't know how to behave and put the whole data inside a paragraph :

<p>General DetailsA top sidebar</p>

Needless to say: it becomes ugly.

<dt>and <dd> were meant for small article sections. I think it was already here in previous version but we may have changed the size condition on what a small section is. It's now the case for all section with less that 100 caracters.

The easy way to solve it would be to replace it by :

<h3>General Details</h3>
<p>A top sidebar</p>

We will have <h2> tags for big sections and <h3> for small ones.

I will with Atropos if he prefers making the editor works with <dt> tags.

[cswendrowski]

In GitLab by @adrien.schiehle on Sep 30, 2021, 14:47

My bad, answered to hastly. The <dl> tag was missing.

Patch in progress

[cswendrowski]

This issue has been fixed!