Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adding virtual NTFS filesystem more resilient #691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Apr 25, 2024

Fixes #703

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 75.17%. Comparing base (34c4aeb) to head (a75a271).

Files Patch % Lines
dissect/target/helpers/loaderutil.py 38.88% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
- Coverage   75.20%   75.17%   -0.03%     
==========================================
  Files         292      292              
  Lines       24819    24834      +15     
==========================================
+ Hits        18665    18669       +4     
- Misses       6154     6165      +11     
Flag Coverage Δ
unittests 75.17% <38.88%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding virtual NTFS filesystem should be more resilient
2 participants