-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Angular ~1.3.0 #17
Comments
It is not working? Give me some information. |
I don't get any errors on the console, it just doesn't show the popup messages. I am using latest version of angular and angular-animate (~1.3.0) |
It is not happening to me. The only difference is that in 1.3, toasts goes in a different direction. Something I have to resolve. |
You were mixing there angular version beta.16 and the latest master animate, so it fails. |
ok I updated the version of both files to v1.3.0-build.3121+sha.a4520a7 |
I downgraded the version to 1.3.0-beta.16 and seems to be working. Thanks! |
Seems to break again with 1.3.0-rc.0, they just don't show up at all (I'm using the same version between angular/animate/etc)
|
can you do a |
|
You have to keep in mind that 1.3.x versions are unstable. |
Stupid question, but isn't that downgrading? I do believe it works then (haven't tried it yet, but notifications used to work before I upgraded to rc1) |
You are correct, I meant downgrading |
Angular team is having a hard time with ngAnimate in versions 1.3.x, many issues are being reported. 1.3.0-rc.0 is an unstable version tho, I would recommend you to downgrade it in the meantime. |
Oh I gotcha, good thinking. Thanks! |
There is a breaking change on the RC-0. Basically a callback vs promise. I need to think if I am going to release a version 0.5 to support only 1.3 and leave 0.4 for 1.2 or somehow try to support both. WDYT? |
sounds good, support version 1.2 just for a while and drop it once version 1.3 reaches stabilization |
lmk if I can contribute somehow |
+1 for 1.3 support. Sweet module btw. |
When the 1.3 comes out I will release a new version which will break 1.2 compatibility. For now, there are two |
Would it make sense to branch off and implement that fix? Or just wait? I ended up just including toastr globally instead of in an angular.module. Seem's most angular-toaster libraries are broke in v.1.3.x |
1.3-rc.0 made a big BC on animations. Let me do the branch, that is easy to do. |
Alrighty, there is a |
👍 Thanks! |
New version, new release. |
so, is it the new version in the master branch? |
Yeah, version |
bower.json has version 0.3.0 on it, I think the code is the latest, just need to update the version :) |
Oh, true, damn bower, will fix that asap. |
ImI |
No description provided.
The text was updated successfully, but these errors were encountered: