Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower install does't download angular-toastr.tpls.js and angular-toastr.tpls.min.js #43

Closed
zahidmak opened this issue Feb 12, 2015 · 5 comments

Comments

@zahidmak
Copy link

Really great work. but one issue as mentioned above. If you could resolve this it would be great.
Thanks

@theblang
Copy link

It does download them, but the main attribute in bower is set to use angular-toastr.js rather than angular-toastr.tpls.js. This causes an issue if you are relying on main for grunt or gulp.

@Foxandxss Was using angular-toastr.js in main intentional?

@Foxandxss
Copy link
Owner

@mattblang no. In the past there was only angular-toastr and not angular-toastr.tpls.js and I forgot to change that on bower.

Since I am not a fan of bower, what should I put? Both files or just the tpls one?

@Foxandxss
Copy link
Owner

I set tpls to be the one installed. Will be on beta.3 which I will release today and if everything goes well for a week, I will release the final version.

@zahidmak
Copy link
Author

Thanks @Foxandxss for quick response on my email. beta 3 has tpls file. It would be great if you release the final version.

@Foxandxss
Copy link
Owner

@zahidmak you can bower install angular-toastr#1.0.0-beta.3 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants