Second round of feedback #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brianegan Brian, once again, thank you for your valuable feedback! 💙 As usual, your suggestions are great and to the point. Thank you for taking time to review it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great updates, Anna! I've gone through the workshop once more, providing feedback inline. Like last time, please feel free to accept whatever is helpful and disregard the rest :)
Overall, I'm super impressed with this workshop. The flow is great, you set up future steps (AppBar theming in the Icons step), and refer back to them later (scrolledUnder is a great tip). I can't think of much to improve here!
Total time to take the workshop and write feedback inline: 1hour 14mins