Shell completions are corrupted.

[igo95862]

All of shell completions have this binary string at the end.

In less it looks like this:

ESC(BESC[m

Probably an issue with upstream library?

[Foxboron]

This is an inherent issue with how I have implemented the terminal colors. All commands are closed off with that escape code for no good reason.

https://github.com/Foxboron/sbctl/blob/master/cmd/sbctl/main.go#L352

I should try and implement the new command structure with the cli output to fix this :/ Is it completely broken with fish? zsh works fine with the escape at the bottom.

[igo95862]

Is it completely broken with fish?

Yes. Fish is strict about script formatting.

[igo95862]

BTW. Why not write to some file directly instead of stdout? Probably avoids the issue but require slight PKGBUILD modification.

[Foxboron]

I think generally restructuring the AddCommand section to add PostRun with the off switch on everything except the completion stuff is the way to go.

[igo95862]

I think it is also possible to send control sequences in to stderr instead of stdout. Usually but will be linked to same pipe as stdout but in case of shell redirect > only stdout will be redirected.

[igo95862]

Ok. I tested changing fmt.Print(off) to fmt.Fprint(os.Stderr, off) and it works. Shell scripts are no longer corrupted and colors are still displayed. This is a one line change.