Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements #35

Closed
foxfriends opened this issue Nov 30, 2020 · 2 comments
Closed

Performance improvements #35

foxfriends opened this issue Nov 30, 2020 · 2 comments
Labels
wontfix This will not be worked on
Projects
Features

Comments

@foxfriends
Copy link
Owner

After #34 performance is much better but I'm sure there can still be more. It's just not as critical anymore. Maybe some Rc can be added to patterns (in place of boxes? in other places?) to speed up cloning even further.
@foxfriends foxfriends added this to RFC in Features via automation Nov 30, 2020
@foxfriends foxfriends moved this from RFC to To do in Features Nov 30, 2020
@foxfriends
Copy link
Owner Author

Based on some profiling, it seems like most of the time currently is spent doing Binding::transfer_from, probably because there is no sharing between the two bindings, so it takes a long time to clone everything. Adding Rcs to the Pattern might be enough to speed that up.

@foxfriends
Copy link
Owner Author

Closing in favour of #47

Features automation moved this from To do to Done Jan 28, 2021
@foxfriends foxfriends added the wontfix This will not be worked on label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
Features
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@foxfriends