frontend: Cleanup various minor bugs #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code ligatures, as it is likely not obvious to kids that `≧` is a ligature for `>=`. In evy we want the loaded code to display as `>=`, no `≧` (same for != and others). I was not aware that his could be fixed in CSS until now.
Fix modal background colour to be 5% transparent. This must have been a rebase muck up because I recall I fixed this before.
Ensure navigation to home (no hash in URL) via browser back/forward button works. Currently when selecting a sample and then navigating back home the contents don't change.
Fix bug navigation bug, where clicking on the current item doesn't hide navigation modal. The reason was that when the hash changes, handleHash calls hideModal, but the hash didn't change for the same item, now hideModal is always called (sometimes twice, but we are ok with that).
Slide to code screen when navigating to new code sample on mobile. Otherwise we might stay on the output screen, possible still with the stopped output of the previous sample which is confusing. Later we may introduce some #autorun which will keep things on mobile on the output screen and run the new code.
juliaogris
force-pushed
the
frontend-tweaks
branch
from
94d359d
to
558633f
Compare
|
firebase-deployment: https://evy-lang--100-oznqidp0.web.app (558633f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styling:
JS:
fix minor navigation bugs