lexer: Fix empty string lit in middle of line #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--118-egl2quu7.web.app (0bd98db) |
Fix empty string lit in middle of line. As we advance at the beginning of reading string and then again when peekRune is `"` we overshoot for empty strings `""`. Fix this be doing the outer advance only at the end of the iteration.
juliaogris
force-pushed
the
empty-string-lit-fix
branch
from
dcb0672
to
0bd98db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix empty string lit in middle of line. As we advance at the beginning
of reading string and then again when peekRune is
"we overshoot forempty strings
"". Fix this be doing the outer advance only at the endof the iteration.