docs: Enforce at least one statement in blocks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
grammar-update
branch
from
669914c
to
88f0828
Compare
|
Visit the preview URL for this PR (updated for commit f42c5d6): https://evy-lang--pr20-grammar-update-hbhbu1sx.web.app (expires Thu, 22 Sep 2022 06:13:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Reorder productions from higher level: program, function declaration, if statement, to single line statement and eventually expression, term and TERMINAL. Reviewing the grammar again this seemed like the more natural flow. This is a non-functional change.
Update grammar to enforce at least one statement in blocks. This means each function declaration, if statement, while statement etc. need to have at least one statement in the inner block. Like in Go's "variable declared but not used" error message we want to catch accidental omissions and limit the set of "valid programs" to provide more guide rails. The parser will be updated in a follow up PR.
juliaogris
force-pushed
the
grammar-update
branch
from
88f0828
to
f42c5d6
Compare
juliaogris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update grammar to enforce at least one statement in blocks. This means
each function declaration, if statement, while statement etc. need to
have at least one statement in the inner block. Like in Go's "variable
declared but not used" error message we want to catch accidental
omissions and limit the set of "valid programs" to provide more guide
rails.
The parser will be updated in a follow up PR.
While at it, reorder the production rules in the grammar to flow more
naturally from higher order constructs, to single line statements,
expressions and TERMINALS.