Implement while statement parsing and evaluation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intern basic parser types - Number, String, Bool, any - to make pointer comparison trivial without requiring deep comparison.
|
Visit the preview URL for this PR (updated for commit 6284a93): https://evy-lang--pr22-while-9nzpficc.web.app (expires Tue, 11 Oct 2022 22:45:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
camh-
approved these changes
Oct 4, 2022
pkg/evaluator/scope.go
Outdated
| return nil, false | ||
| } | ||
| if _, ok := s.values[name]; ok { | ||
| return s, ok |
There was a problem hiding this comment.
nit: I would make this return s, true. Since ok is always true in this branch, the literal makes it easier to read and understand at a glance.
Fix setting variable value in correct scope. The variable value needs to be updated in the scope the variable was declared rather than in the current scope so that an update inside a block is still available when the block has terminated.
Ensure the value of a `return` is propagated along with whether a conditional block was executed as `val, ok`. Previously we only returned TRUE or FALSE for branch taken or not which swallowed returned statements.
Implement while statement parsing and evaluation. Reuse conditional Block execution from If-statements parsing and evaluation and factor out shared code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement while statement parsing and evaluation by reusing conditional
Block execution from If-statements parsing and evaluation and factor
out shared code.
Fix various bugs that popped up while implementing while statements: