parser: Harden return statements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0b2202d): https://evy-lang--pr23-return-errors-qvps6m8p.web.app (expires Wed, 12 Oct 2022 08:16:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Unify statement parsing for program and block - just a small refactor in order to not repeat myself.
juliaogris
force-pushed
the
return-errors
branch
4 times, most recently
from
ceff6b7
to
50c8cc5
Compare
camh-
reviewed
Oct 5, 2022
juliaogris
force-pushed
the
return-errors
branch
2 times, most recently
from
069ee1f
to
57c421e
Compare
Ensure correct return type according to function signature, append error otherwise.
Add error message for unreachable code after `return` statement.
Ensure functions with specified return type always return, print error otherwise.
juliaogris
force-pushed
the
return-errors
branch
from
ae665c7
to
0b2202d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harden return statements such that there is an error when there is
unreachable code after a return statement or a return statement is of
the wrong type.