Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Crank up the linting settings #25

Merged
merged 1 commit into from
Oct 5, 2022
Merged

go: Crank up the linting settings #25

merged 1 commit into from
Oct 5, 2022

Conversation

juliaogris
Copy link
Member

Crank up the linting settings so that linter runs in stricter mode and
catches more errors, before the codebase gets too big. Disable quite a few
annoying linters.

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Visit the preview URL for this PR (updated for commit ae269b8):

https://evy-lang--pr25-crank-linting-hvmoz25h.web.app

(expires Wed, 12 Oct 2022 21:53:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -27,12 +27,12 @@ type BuiltinFunc func(args []Value) Value
func (b BuiltinFunc) Type() ValueType { return BUILTIN }
func (b BuiltinFunc) String() string { return "builtin function" }

func DefaultBuiltins(print func(string)) Builtins {
Copy link
Contributor

@camh- camh- Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 Can I just say: Ha!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍭

Crank up the linting settings so that linter runs in stricter mode and
catches more errors, before the codebase gets too big. Disable quite a
few annoying linters.
@juliaogris juliaogris merged commit 9f1c570 into master Oct 5, 2022
@juliaogris juliaogris deleted the crank-linting branch October 5, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants