github: Add PR comment with deployment URL #27

juliaogris · 2022-10-06T03:09:33Z

Move firebase deployment and PR commenting machinery into separate
script as it is a bit verbose for a Makefile.

juliaogris · 2022-10-06T06:11:31Z

firebase-deployment: https://evy-lang--dev-jjp3kzei.web.app ()

juliaogris · 2022-10-06T06:13:50Z

firebase-deployment: https://evy-lang--dev-jjp3kzei.web.app (66d8938)

camh-

a few comments to get you going

firebase/deploy

github-actions · 2022-10-06T11:17:16Z

firebase-deployment: https://evy-lang--dev-jjp3kzei.web.app (05417a0)

github-actions · 2022-10-06T11:17:54Z

firebase-deployment: https://evy-lang--dev-jjp3kzei.web.app (fe74987)

juliaogris · 2022-10-06T11:22:38Z

firebase-deployment: https://evy-lang--dev-jjp3kzei.web.app (fe74987)

gh api -H "Accept: application/vnd.github+json" /repos/foxygoat/evy/issues/27/comments
finds this last comment as

 {
    "url": "https://api.github.com/repos/foxygoat/evy/issues/comments/1269841022",
    "html_url": "https://github.com/foxygoat/evy/pull/27#issuecomment-1269841022",
    "issue_url": "https://api.github.com/repos/foxygoat/evy/issues/27",
    "id": 1269841022,
    "node_id": "IC_kwDOHw9lvM5LsDx-",
    "user": {
      "login": "github-actions[bot]",
      "id": 41898282,
      "node_id": "MDM6Qm90NDE4OTgyODI=",
      "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/github-actions%5Bbot%5D",
      "html_url": "https://github.com/apps/github-actions",
      "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers",
      "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}",
      "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions",
      "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs",
      "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos",
      "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}",
      "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events",
      "type": "Bot",
      "site_admin": false
    },
    "created_at": "2022-10-06T11:17:54Z",
    "updated_at": "2022-10-06T11:17:54Z",
    "author_association": "NONE",
    "body": "firebase-deployment: https://evy-lang--dev-jjp3kzei.web.app (fe7498793d529ec5334575a7cdcdc259d1e6d72c)",
    "reactions": {
      "url": "https://api.github.com/repos/foxygoat/evy/issues/comments/1269841022/reactions",
      "total_count": 0,
      "+1": 0,
      "-1": 0,
      "laugh": 0,
      "hooray": 0,
      "confused": 0,
      "heart": 0,
      "rocket": 0,
      "eyes": 0
    },
    "performed_via_github_app": null
  }

Makefile

firebase/deploy

github-actions · 2022-10-06T11:36:00Z

firebase-deployment: https://evy-lang--dev-jjp3kzei.web.app (23a11b5)

camh-

💚 I think you've done this script really well. Good on you for giving it a go and realising it's not that hard

firebase/deploy

.github/workflows/cicd.yaml

firebase/deploy

github-actions · 2022-10-06T22:07:46Z

firebase-deployment: https://evy-lang--pr27-uzv43y0r.web.app (f01a430)

HELLO!!!

github-actions · 2022-10-06T22:18:46Z

UPDATED

Howl with an `@here` on Foxygoat slack when the master build fails. We want to know about this as evy is continuously deployed to Firebase.

github-actions · 2022-10-06T22:56:33Z

firebase-deployment: https://evy-lang--27-g4j30emv.web.app (2d8b7b0)

Move firebase deployment and PR commenting machinery into separate script as it is a bit verbose for a Makefile. Post comment with new deployment URL derived from PR number and git sha of deployed commit. Update comment if already posted previously. The script can also be run locally and does not comment on a PR with `make firebase-deploy` which deploys to to `dev` channel. On CI `make firebase-deploy` the deploy scrip finds the active PR number and deploys to channel `prNN`. To deploy to prod run `make firebase-deploy-prod` which deploys to the live channel. Signed-off-by: Julia Ogris <julia.ogris@gmail.com>

camh-

💚 So happy to see your skills growing here.

juliaogris force-pushed the pr-comment branch from ec4a85f to 309ea60 Compare October 6, 2022 03:12

juliaogris changed the title ~~github: Fix continuous deployment for master~~ github: Add PR comment with temp deployment URL Oct 6, 2022

juliaogris force-pushed the pr-comment branch 4 times, most recently from 85156c6 to c9b1328 Compare October 6, 2022 05:28

juliaogris changed the title ~~github: Add PR comment with temp deployment URL~~ github: Add PR comment with deployment URL Oct 6, 2022

juliaogris force-pushed the pr-comment branch 6 times, most recently from 9ef6a7c to 16fa540 Compare October 6, 2022 06:10

juliaogris force-pushed the pr-comment branch from 16fa540 to 66d8938 Compare October 6, 2022 06:13