evaluator: Add map and array literals #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--38-kypt33yb.web.app (3e0a252) |
Add map and array literals. We should have done this a while back. Oversight.
juliaogris
force-pushed
the
eval-arraylit
branch
from
2be7060
to
3e0a252
Compare
juliaogris
added a commit
that referenced
this pull request
Oct 19, 2022
Add index and dot expression evaluation in evaluator, similar to binary expression evaluation. Change Array.Elements and Map.Order to pointer. This is another preparatory step for proper array and map manipulation so that two variables may reference the same array or map and if one gets updated the other one will get updated too. Rework scoped Value updates such that instead of replacing the value in the scope on assignment with scope.set(name, newValue), we now update the Value field with scope.get(name).Set(newValue) --- The first three commits are covered by PRs #37 and #38 . This merges the following commits: * parser: Fix IndexExpression.Type() for indexed string * parser: Fix missing early return on index error * evaluator: Rework scoped Value updates * evaluator: Change Array.Elements and Map.Order to pointer * evaluator: Add index and dot expression evaluation * evaluator Rename local variable for consistency pkg/evaluator/builtin.go | 2 +- pkg/evaluator/evaluator.go | 100 +++++++++++++++++------- pkg/evaluator/evaluator_test.go | 87 ++++++++++++++++++++- pkg/evaluator/scope.go | 10 --- pkg/evaluator/value.go | 131 +++++++++++++++++++++++++++----- pkg/parser/expression.go | 9 ++- pkg/parser/expression_test.go | 4 + pkg/parser/parser_test.go | 4 + 8 files changed, 286 insertions(+), 61 deletions(-) Pull-Request: #39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add map and array literals to evaluation. We should have done this a
while back. Oversight.
Only the last commit is relevant of this PR, It depends on #37 to be
merged first (too many conflicts).