eval: Fix any's wrapping any's #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
eval-any-fix
branch
2 times, most recently
from
b05cbee
to
a5cd042
Compare
|
firebase-deployment: https://evy-lang--42-o3su607s.web.app (a9e883a) |
juliaogris
force-pushed
the
eval-any-fix
branch
2 times, most recently
from
1337ceb
to
d164154
Compare
Reorder `make ci` dependences to float more common errors early. At this stage the linter catches me out the most often and I'd like to know about this before running the rather slow tiny go build and tests.
Fix `any`'s wrapping `any`'s so that `any` only ever contains a non-`any` type. We have added two test cases that failed before the code fix in the evaluator.
juliaogris
force-pushed
the
eval-any-fix
branch
from
d164154
to
a9e883a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
any's wrappingany's so thatanyonly ever contains anon-
anytype. We have added two test cases that failed before the code fix.Sneak in a
make cidependency reorder so that linter errors surface earlier.