all: Rework evy-evaluation to be hoisted on main #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix erroneously overridden env object, completely this time. While we added the fix in 4d25139 we forgot to override the broken lines. oups.
Simplify go.env definition so that we don't repeat key:val where key and val are the same.
Remove lex and parse from wasm and frontend as these were only used in the early stages to debug code. The buttons for lex and parse had been hidden for a while - let's simplify and remove all bindings completely.
|
firebase-deployment: https://evy-lang--65-092fjtga.web.app (43ca51c) |
juliaogris
force-pushed
the
wasm-main-entry
branch
from
a2915d8
to
9819141
Compare
camh-
reviewed
Feb 5, 2023
camh-
approved these changes
Feb 5, 2023
juliaogris
force-pushed
the
wasm-main-entry
branch
from
9819141
to
c09addf
Compare
camh-
approved these changes
Feb 5, 2023
juliaogris
force-pushed
the
wasm-main-entry
branch
3 times, most recently
from
954f24e
to
31593d2
Compare
Launch wasm from go `main()` rather than from go exported function `evaluate()`. It turns out that some things, such as time.Sleep and fmt.Sprintf only get properly intialised with the main function is the entry point to the wasm code, so let's fix this up. We cannot pass parameters to main() so we need JS to provide function to extract the evy source as string. Unfortunately we can't pass strings directly in wasm so we have write bytes to linear memory. This was fine when passing strings as function arguments, but when we want return values this falls apart as wasm can only provide a single return value. I attempted to make this single return value a pointer in memory where the first 4 bytes contain the length and the following bytes the contents of a string, but got lost with endian specs and other details. Instead JS provides the somewhat hacky functions `sourcePtr` and `sourceLength`, which are called separate from Go code and reassembled to a string.
juliaogris
force-pushed
the
wasm-main-entry
branch
from
31593d2
to
43ca51c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework evy-evaluation to be hoisted on main rather than the separately
exported
evaluatefunction. Some things, such as time.Sleep andfmt.Sprintf only get properly initialised if the main*() function is
the entry point to the wasm code.
Additional, we had to solve to problem of having a JS function
returning a string in memory - we've done this in a hacky way by
returning Ptr and Length in separate function calls.
In preparation remove Lex and Parse button and wasm bindings.