all: Implement stop #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--67-4souifjv.web.app (aba3e29) |
juliaogris
force-pushed
the
cancel
branch
3 times, most recently
from
6bad444
to
2eeac0a
Compare
juliaogris
force-pushed
the
cancel
branch
3 times, most recently
from
c9407b6
to
f100376
Compare
Refactor access to builtin functions and decls so that we can create the evaluator in wasm main and hold on to it in global state. This will later be needed so that we can set a cancel flag in the evaluator during execution in a JS exported function.
camh-
approved these changes
Feb 8, 2023
pkg/evaluator/evaluator.go
Outdated
| if e.Stopped { | ||
| return ErrStopped | ||
| } | ||
| e.yield() |
There was a problem hiding this comment.
Perhaps a comment here to say why this yield exists?
// Yield to give JavaScript/browser events a chance to run.
| print func(string) | ||
| builtins map[string]Builtin | ||
|
|
||
| scope *scope // Current top of scope stack | ||
| } | ||
|
|
||
| type Yielder interface { |
There was a problem hiding this comment.
a comment perhaps?
// Yielder abstracts the method of yielding the CPU so that JavaScript/browser
// events get a chance to be processed. Currently (Feb 2023) it seems that you
// can only yield to JS by sleeping for at least 1ms but having that delay is
// not ideal. Other methods of yielding can be explored by implementing a
// different Yielder.
pkg/wasm/main.go
Outdated
| @@ -24,6 +27,26 @@ func getSource() string { | |||
| return getString(ptr, length) | |||
| } | |||
|
|
|||
| type yielder struct { | |||
There was a problem hiding this comment.
perhaps call this sleepingYielder or something?
Implement stop in frontend by turning the Run button into a Stop button during execution. For this we also need an onExit callback into JS from go when execution finishes so that the button label gets reset. Additionally we need to occasionally yield to JS event processing via a `time.Sleep` in the evaluator code. This operation is abstracted via the Yielder interface. Execution is stopped in Eval if the Stopped flag is set, which gets set on click via the exported Go function stop(). The access to the stop flag is not synchronized, but as JS is single threaded so we don't need to worry about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement stop in frontend by turning the Run button into a Stop button
during execution. For this we also need an onExit callback into JS from
go when execution finishes so that the button label gets reset.
Additionally we need to occasionally yield to JS event processing via a
time.Sleepin the evaluator code. This operation is abstracted viathe Yielder interface.
Execution is stopped in Eval if the Stopped flag is set, which gets set
on click via the exported Go function stop(). The access to the stop
flag is not synchronised, but as JS is single threaded so we don't need
to worry about it.
In a preparatory commit refactor evaluator and builtins so that there is
a separate
NewEvaluatorfunction ande.Runmethod. This allows forwasm/main.goto hold an evaluator as global variable on which we set theevaluator.Stoppedflag.Evy program for testing.
another one with sleep: