evaluator: Tighten error handling with panics #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--68-60kb6aej.web.app (045b695) |
Panic with internal errors for Value.Set/Equals instead of silently swallowing incorrect types to this methods. The initial plan of returning errors seems to cumbersome for states that are evy internal errors and _should_ probably halt an evy program in execution. Unfortunately tinygo doesn't currently implement recover.
Tighten error handling and panic on unknown node type for Eval function, previously we just returned nil which seemed to only take effect for FuncDecls and inferred slice beginnings and end. Fix these up in the place where they are expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tighten error handling with panics rather than returning false or nil so
that we can track down errors more easily in when they are a result of
internal coding errors.