parser: Update eventHandler parsing for parameters and bare return #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
force-pushed
the
on
branch
2 times, most recently
from
3a7a5d1
to
9f5d315
Compare
|
firebase-deployment: https://evy-lang--70-nrwpfmke.web.app (63feee0) |
juliaogris
force-pushed
the
on
branch
2 times, most recently
from
8a25888
to
f0fd036
Compare
camh-
reviewed
Feb 9, 2023
camh-
approved these changes
Feb 15, 2023
| print "func x" | ||
| end | ||
| for x := range 10 | ||
| print "x" x |
There was a problem hiding this comment.
nit: there's a mixture of 4-space indent and tab indent in the evy fragments throughout this file. This change adds more mixture (one of each). Maybe a trivial cleanup of it all later?
There was a problem hiding this comment.
🍍 Perhaps ignore this for now since it may be painful to restack all your other PRs - this is my only comment and it's just a nit
Add variable validation in for statements. In specific, variable declared in the as `for VAR := range ...` should follow the same validation rules as other variable declarations. It's been an oversight.
Use validateVarDecl in parameters rather than duplicating the validation for the sake of slightly more accurate error messages.
Update eventHandler parsing for parameters and bare return. In follow up commits we will add valid builtin eventHandler names and signatures and add evaluation.
Validate eventHandlers against builtin names and parameters, such that `on unknown_event` errors and eventhandlers with wrong types of parameters also error. It is valid to drop all parameters in the source if they aren't used.
juliaogris
added a commit
that referenced
this pull request
Feb 15, 2023
Wire eventHandler to frontend so that when `on <event>` block appears in evy code the corresponding frontend event triggers the execution of that block. Currently implemented events: `down`, `up`, `move`, `key`. Only `frontend:` and `all:` commits are relevant, the `parser:` commits are covered in #70 Sample code https://evy-lang--73-51oq7tbx.web.app#draw on down x:num y:num print "down" x y end on up print "up" end on key c:string print "key" c end simple drawing tool d := false width 1 on down x:num y:num d = true move x y end on up d = false end on move x:num y:num if d line x y end end This merges the following commits: * frontend: Add memToString and stringToMem * frontend: Unify naming and add comments * frontend: Optionally load evy source via URL fragment * frontend: Refactor canvas scale parameters * all: Implement up, down, move and key events frontend/index.js | 125 ++++++++++++++++++++++++++++++++----- frontend/samples/dot.evy | 18 ++++++ frontend/samples/draw.evy | 17 +++++ pkg/evaluator/evaluator.go | 51 +++++++++++++-- pkg/evaluator/value.go | 25 ++++++++ pkg/parser/parser.go | 8 +-- pkg/wasm/main.go | 78 +++++++++++++++++++++-- 7 files changed, 292 insertions(+), 30 deletions(-) Pull-Request: #73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update eventHandler parsing for parameters and bare return. Add builtin
eventHandler declarations for known even names and parameters.
In preparation fix for loop variable declaration validation and unify
parameter declaration validation with variable declaration validation.
This is part one of a two part PR. The second Part will add evaluation and
wiring with frontend.