builtin: Add printf and sprintf functions #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--77-a1lie1rx.web.app (7c7c57f) |
camh-
reviewed
Feb 15, 2023
camh-
approved these changes
Feb 15, 2023
juliaogris
force-pushed
the
printf
branch
2 times, most recently
from
fc5a244
to
72d37c7
Compare
Fix evaluator failed test output from to print the output (`out`) rather
than the slice of lines which gives a for which we got on failed tests
the useless:
panic: interface conversion: interface {} is []string, not string [recovered]
panic: interface conversion: interface {} is []string, not string
Add printf and sprintf functions using Go's fmt.Sprintf (which now that we hoist wasm code via main works 馃殌). To allow for formatted printed of numbers and bools add and `unwrap` function to value.go, unwrapping the value of the Value interface implementation for basic types only. In the process of creating printf, we discovered some missing unescaping in the lexing stage as the goal is to keep string handling consistent with Go and print "\n" as newlines. Fix it and improve error message for invalid strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add printf and sprintf functions using Go's fmt.Sprintf (which now that we
hoist wasm code via main works 馃殌). To allow for formatted printed of
numbers and bools add and
unwrapfunction to value.go, unwrapping thevalue of the Value interface implementation for basic types only.
In the process of creating printf, we discovered some missing unescaping in
the lexing stage as the goal is to keep string handling consistent with Go
and print "\n" as newlines. Fix it and improve error message for invalid
strings.
While at fix evaluator test output for multiline test cases and failed
tests.