all: Add read function #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment: https://evy-lang--79-se5aqk1b.web.app (3595abe) |
juliaogris
force-pushed
the
read
branch
2 times, most recently
from
9c9af92
to
4c62f13
Compare
Upgrade tinygo to v0.27.0 with
hermit install tinygo-0.27.0
Tinygo's dependencies go and gofmt get upgraded to 1.20. As a result
linters failed (not linting, but linters(!)) so upgrade golangci-lint
and its settings.
Rework access to evy source code. What we wanted was a JS function that returns a string (the evy source code). However, go/wasm only allows JS functions that return float64, int, int32 or uint32 it seems. As a result we queried the global sourcePointer and sourceLength as written to linear memory separately and rebuilt the string in go wasm. Now that we will need another string returning functions (read()) it is time to rework this approach: Write the string to memory in JS all the same, but combine pointer (high 32 bits) and length (low 32 bits) into a single 64 bit JS Number which is return to in go/wasm as float64. Reconstruct pointer and length from it in go/wasm with the inverse bit manipulations and reconstruct string. It could be that passing float64 is going to bite as at some point - we will deal with it.
Add blocking read function for line-by-line reading from text input. Add jsRead function to index.js which returns a memory address of read string iff a string has been entered into the input area followed by a newline, otherwise return 0. go/wasm provides read() which wraps jsRead() in a loop with intermittent sleeps to yield to JS for processing user events. If the return value of jsRead() is not 0 extract the string for the given memory address and return. read() is provided to the evaluator via the runtime struct and used inside the evy builtin read. Move `hidden` class towards the end of index.css because for it so that the same property `display` can be overriden from `flex` to `none`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add blocking read function for line-by-line reading from text input.
Rework access to "returned" strings for function imported from JS to
go/wasm, used in getting evy source and readline. To achieve blocking
reads while allowing interactivity in JS code sleep for 50ms between
every unsuccessful read attempt in go/wasm.
Try it with
https://evy-lang--79-se5aqk1b.web.app#echo