all: Add on input handler
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use querySelector instead of getElementById to unify usage for with the follow-up commit where we would need getElementByClassName, which is less recommended than use of querySelect. For a more detailed discussion see https://stackoverflow.com/a/26848360
|
firebase-deployment: https://evy-lang--80-k6pkxs0k.web.app (2109d91) |
Hide and show evy widgets via URL fragment so that we can hide sliders by default but demonstrate their use in the follow up commits, e.g.: http://evy.dev/#show=.read,.slider&hide=.canvas,.output Note that the value of `show` and `hide` is directly used as querySelector. If elements are to be selected by className a leading dot is required.
Add `on input id:string val:string` handler, so that evy can react to any kind of input event, depending on how the frontend has wired it. By default we have added and hidden to sliders in the index.html / DOM. An example can be explored at https://evy.dev#show=.slider&source=samples/slider.evy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
on input id:string val:stringhandler, so that evy can react to anykind of input event, depending on how the frontend has wired it. By default
we have added and hidden to sliders in the index.html / DOM.
An example can be explored at
https://evy-lang--80-k6pkxs0k.web.app#show=.slider&source=samples/sliders.evy
In preparation change visibility of evy-widgets in dom via URL fragment.