Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for GFWlist? #74

Closed
Daymond opened this issue Apr 1, 2020 · 12 comments
Closed

[Feature Request] Support for GFWlist? #74

Daymond opened this issue Apr 1, 2020 · 12 comments
Labels
feature request New feature or request

Comments

@Daymond
Copy link

Daymond commented Apr 1, 2020

Is there any possibility to support GFWlist?

@ericjung
Copy link
Collaborator

ericjung commented Apr 5, 2020

Yes, I can add support for that.

@Daymond
Copy link
Author

Daymond commented Apr 8, 2020

Yes, I can add support for that.

Thanks so much.

@woosley
Copy link

woosley commented Jun 17, 2020

Hi, I think what is needed is a common way to import whitelist pattern from url/file.

@ericjung
Copy link
Collaborator

Yes, I agree. There is another feature request for this. Old FoxyProxy (pre Firefox-57) had this feature. I will add it again, but accept pull requests for help.

@117649
Copy link

117649 commented Oct 13, 2021

@ericjung It has been a year now. Any light on this?

@ericjung
Copy link
Collaborator

ericjung commented Dec 8, 2021

Not yet, but as I said, I will accept merge requests for it.

@erosman
Copy link
Collaborator

erosman commented Sep 10, 2022

Looking at one GFWlist, it has 8400+ rules.

  • Pages often make 100+ of net connections (for each of its components e.g. images, CSS, etc) and checking against 8400+ rules for each of the net connection can slow down page loading and create unwanted load on CPU & RAM
  • From personal experience, most users may only need or use 100 of those rules therefore including 8400+ rules that contains sites that might never be visited is not efficient
  • Creating/displaying 8400+ rules will slow down the UI

@erosman erosman added the feature request New feature or request label Sep 10, 2022
@20NE
Copy link

20NE commented Sep 10, 2022

Never mind, firefox already supports PAC file.

@erosman
Copy link
Collaborator

erosman commented Sep 10, 2022

Never mind, firefox already supports PAC file.

PAC is also supported in FoxyProxy v8.0 (once released).

@ericjung
Copy link
Collaborator

@erosman i don’t see GWList as a PAC file anywhere. How is PAC related to this?

@erosman
Copy link
Collaborator

erosman commented Sep 10, 2022

I didn't search for GWList PAC but I assumed it is available based on the previous post and the fact that it is possible to make a PAC based on GWList.
The URL for such PAC then can be entered as PAC URL in FoxyProxy v8.0

@ericjung
Copy link
Collaborator

Looks like it is here:
https://github.com/petronny/gfwlist2pac

@erosman erosman closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants