Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description, manufacturingDate, expiryDate, & size fields in products.json file #2

Conversation

minhajul-karim
Copy link
Contributor

The error was occurring as description, manufacturingDate, expiryDate, & size are defined as required in the product schema but those fields were missing in the products.json file. I have added those fields to the products.json file and the seed is now working.

@foyzulkarim
Copy link
Owner

@minhajul-karim bhai, please remove the package-lock.json file from the PR.
Otherwise it looks awesome. Thanks

@minhajul-karim minhajul-karim changed the title Add description, manufacturingDte, expiryDate, & size fields in products.json file Add description, manufacturingDate, expiryDate, & size fields in products.json file Sep 22, 2021
@minhajul-karim
Copy link
Contributor Author

@minhajul-karim bhai, please remove the package-lock.json file from the PR.
Otherwise it looks awesome. Thanks

Bhaiya, deleted the package-lock.json file from /server

@foyzulkarim
Copy link
Owner

@minhajul-karim bhai, please remove the package-lock.json file from the PR.
Otherwise it looks awesome. Thanks

Bhaiya, deleted the package-lock.json file from /server

Brother, I requested to ignore from the PR, not to delete the file. Please check again.

@minhajul-karim
Copy link
Contributor Author

Bhaiya, I've kept the package-lock.json as is when I created a new branch from feature/incorporate-antdpro. I'm relatively new to the open-source community. Your guidance will be highly appreciated. :)

@foyzulkarim
Copy link
Owner

Bhaiya, I've kept the package-lock.json as is when I created a new branch from feature/incorporate-antdpro. I'm relatively new to the open-source community. Your guidance will be highly appreciated. :)

No worries brother. This is why I am requesting to change, no need to get stressed. :)

Copy link
Owner

@foyzulkarim foyzulkarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. :)

@foyzulkarim foyzulkarim merged commit fec6ff2 into foyzulkarim:feature/incorporate-antdpro Sep 22, 2021
foyzulkarim added a commit that referenced this pull request Sep 29, 2021
* Initial commit to incorporate antd-pro template

* search on going

* Implemented login successfully

* Started tweaking the data flow

* Add description, manufacturingDate, expiryDate, & size fields in products.json file (#2)

* Add description, manufacturingDte, expiryDate, & size fields in products.json

* Delete package-lock.json file

* Keep the contents of package-lock.json same as in branch feature/incorporate-antdpro

* Added access token in the request interceptor

* Login logout and auth check ok. Need refactor now.

* Renitialize initial state and fix request interceptor

* Squashed commit of the following:

commit cdca41c
Author: Foyzul Karim <foyzulkarim@gmail.com>
Date:   Fri Sep 24 22:39:37 2021 +0800

    Changed logic

commit b77df7a
Author: Foyzul Karim <foyzulkarim@gmail.com>
Date:   Fri Sep 24 22:09:16 2021 +0800

    Added environmental variable for client

Co-authored-by: Minhajul Karim <minhajul.kaarim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidationError: Product validation failed error when running npm run db:seed
2 participants