IS_MONGODB_CLOUD_URL turn into boolen #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tusheer bro. Thanks for your pull request. |
|
@tusheer bro you can try to use Nice find. I appreciate your efforts |
foyzulkarim
reviewed
Feb 27, 2022
server/src/core/mongo.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| const mongoose = require("mongoose"); | |||
| require('dotenv').config() | |||
| const isMongoDbUrl = process.env.IS_MONGODB_CLOUD_URL; | |||
| const isMongoDbUrl = Boolean(process.env.IS_MONGODB_CLOUD_URL); | |||
There was a problem hiding this comment.
Thank you Bhaiya for your correction. This is really inspiring when I can communicate with you at least through the code. Happy coding Bhaiya.
foyzulkarim
reviewed
Feb 27, 2022
| @@ -1,6 +1,6 @@ | |||
| const mongoose = require("mongoose"); | |||
| require('dotenv').config() | |||
| const isMongoDbUrl = Boolean(process.env.IS_MONGODB_CLOUD_URL); | |||
| const isMongoDbUrl = JSON.parse(process.env.IS_MONGODB_CLOUD_URL); | |||
There was a problem hiding this comment.
if IS_MONGODB_CLOUD_URL is undefined then we will face the same problem. Let's try JSON.parse(a ? a : 'false') algo for now. 😎
Thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In connectWithDb function when we collect IS_MONGODB_CLOUD_URL from env it gives us a value as a string, So if we check is it false or true it always returns true. So I turn it into a boolean using the Boolean function.