Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant values on both counter blocks #119

Closed
C47D opened this issue Dec 20, 2016 · 1 comment
Closed

Constant values on both counter blocks #119

C47D opened this issue Dec 20, 2016 · 1 comment

Comments

@C47D
Copy link
Contributor

C47D commented Dec 20, 2016

If the counterAsc and counterDes blocks are used on the user project without the constant blocks they use a default value that i left on the component implementation, in case of using the constant blocks the latter constants are used.

It is better left the implementation like this or change the constants inside the blocks or warn the user that no constants are used at the project level?

@C47D C47D changed the title Counter blocks "default" values Constant values on both counter blocks Dec 20, 2016
@Jesus89
Copy link
Member

Jesus89 commented Dec 23, 2016

Neither iverilog nor yosys complain about not adding a verilog module parameter. It automatically uses its default value.
In Icestudio the value inside the constant is the default value for the project. For the code blocks, all their parameters are initialized to 0.
I think we left this standard behaviour for now. In the future we may evaluate if any warning message is necessary.

@Jesus89 Jesus89 closed this as completed Dec 23, 2016
umarcor pushed a commit to juanmard/icestudio that referenced this issue Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants