Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to check for obsolete dev-dependencies #12

Closed
fpgmaas opened this issue Sep 3, 2022 · 1 comment
Closed

Add the option to check for obsolete dev-dependencies #12

fpgmaas opened this issue Sep 3, 2022 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@fpgmaas
Copy link
Owner

fpgmaas commented Sep 3, 2022

Currently, only regular dependencies are checked. dev-dependencies could also be checked, but they are often packages like jupyterlab, black, isort, flake8, which are not imported in the code. So the logic becomes a lot more fuzzy, should we e.g. check makefiles & ci/cd files for the mentioning of these dependencies?

Alternatively, those can be added to an argument dev-dependencies-to-ignore in pyproject.toml (or something similar), and regular python files can be scanned for imports. This can still help to find obsolete dependencies; e.g. a package might have been used in the development of unit tests, but it's no longer actually used.

@fpgmaas fpgmaas added enhancement New feature or request wontfix This will not be worked on labels Sep 3, 2022
@fpgmaas
Copy link
Owner Author

fpgmaas commented Sep 8, 2022

For now added the wontfix label, since this will be quite a large overhaul, and I am wondering if user configuration won't become too confusing. Users would need to specify separately which files and directories to include for both the regular and the development dependency checks.

On the other hand, most of the required classes and functions are already there. Optionally we could add a separate command, so users could run:

deptry .

to check regular dependencies and

deptry dev .

To check the development dependencies.

Anyway, if this issue gains attention in the future, we could always reconsider.

@fpgmaas fpgmaas closed this as completed Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant