Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

development dependencies that should be regular dependencies marked as transitive dependencies #45

Closed
fpgmaas opened this issue Sep 7, 2022 · 0 comments · Fixed by #51
Labels
bug Something isn't working

Comments

@fpgmaas
Copy link
Owner

fpgmaas commented Sep 7, 2022

Describe the bug

Transitive dependencies now catch multiple issues:

  • Transitive dependencies, as it should. Package A depends on B, B is imported, but A is added as dependency.
  • Simple user misconfiguration; files that should be run with dev dependencies are scanned. Can happen e.g. when user overrrides the ignore_directories configuration, but does not add tests in the list.
  • A dependency that is wrongly marked as a development dependency (i.e. it is imported within the codebase).

Expected behavior

We need to either catch these separate issues, or improve logging to reflect the above, so the user knows what to do. It would be relatively simple to also read the dev requirements and warn the user if the above happens.

@fpgmaas fpgmaas added the bug Something isn't working label Sep 7, 2022
@fpgmaas fpgmaas linked a pull request Sep 8, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant