Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rails 6 beta2 #235

Closed
n-rodriguez opened this issue Feb 26, 2019 · 4 comments
Closed

Allow Rails 6 beta2 #235

n-rodriguez opened this issue Feb 26, 2019 · 4 comments

Comments

@n-rodriguez
Copy link

n-rodriguez commented Feb 26, 2019

Hi there!

It could be nice to test this gem with Rails 6 beta 2 :

Bundler could not find compatible versions for gem "actionmailer":
  In gems.rb:
    letter_opener_web was resolved to 1.3.4, which depends on
      actionmailer (>= 3.2)

    premailer-rails was resolved to 1.10.2, which depends on
      actionmailer (>= 3, < 6)

    rails (= 6.0.0.beta2) was resolved to 6.0.0.beta2, which depends on
      actionmailer (= 6.0.0.beta2)

Thank you!

@fphilipe
Copy link
Owner

This shouldn't be a problem. Note that premailer-rails currently requires actionmailer < 6, but by definition of SemVer 6.0.0.beta2 is lower than 6.

See the latest build of master against master of rails: https://travis-ci.org/fphilipe/premailer-rails/jobs/495313952#L562

Also, see this previous issue about rails 6 beta: #231

Thus, try removing your Gemfile.lock and rerunning bundle install.

@n-rodriguez
Copy link
Author

Thus, try removing your Gemfile.lock and rerunning bundle install.

It works! Thank you!

@knagode
Copy link

knagode commented Feb 28, 2019

In Gemfile:
   premailer-rails was resolved to 1.10.2, which depends on
     actionmailer (< 6, >= 3)

   rails was resolved to 6.0.0.beta2, which depends on
     actionmailer (= 6.0.0.beta2)`

I am also getting this. I removed Gemfile.lock, ran bundle install but I still see this error. Any other idea @fphilipe or @n-rodriguez ?

@knagode
Copy link

knagode commented Feb 28, 2019

Oh .. :) Thanks for noticing that I am in wrong repo. Will do as you said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants