Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ternary --with-qd #405

Closed
orlitzky opened this issue Feb 4, 2020 · 1 comment
Closed

Support ternary --with-qd #405

orlitzky opened this issue Feb 4, 2020 · 1 comment

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Feb 4, 2020

I'm packaging fplll for Gentoo, and the --with-qd flag is giving me some trouble. Right now the flag supports two things:

  • Disabling the support via --without-qd. This works OK.
  • Enabling the support via --with-qd=PATH. This only sort-of works.

The main problem with --with-qd=PATH is that there's no way for me to set the path to the right place if the libraries are in e.g. /usr/lib64 and the headers in /usr/include. If /usr/lib points to 32-bit libraries on a multilib system, passing --with-qd=/usr will try to link those 32-bit libraries into a 64-bit fplll. No bueno.

On the other hand, if I don't supply the path, then the bare --with-qd sets the path to the literal value "yes". And that doesn't work, because there are no libraries in yes/lib.

Would it be possible to add another case for x$with_qd = "xyes", that will use the standard system locations for the library and headers? That would avoid the first problem in my case: if you do an AC_SEARCH_LIBS on a 64 bit system, it should only find 64 bit libs.

@malb
Copy link
Collaborator

malb commented Feb 7, 2020

I agree, this should be done. Any chance you could provide a PR? Otherwise, I'll try to get around to it when I can.

@malb malb closed this as completed in 33c4178 Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants