Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused serial input port to typed output port connector function #256

Closed
tiffany1618 opened this issue May 22, 2023 · 0 comments · Fixed by #258
Closed

Remove unused serial input port to typed output port connector function #256

tiffany1618 opened this issue May 22, 2023 · 0 comments · Fixed by #258

Comments

@tiffany1618
Copy link
Collaborator

Serial ports should never be connected to typed ports that have a return type. Therefore, serial input port to typed output port connector functions should not be generated when the typed output port has a return type.

For example, this function should not be generated:

https://github.com/fprime-community/fpp/blob/71932e3f0a58fa60046273776e0b2f401e005505/compiler/tools/fpp-to-cpp/test/component/ActiveTestComponentAc.ref.cpp#L1171-L1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants