Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Detect “No preview available” when generating thumbs #56

Closed
andylolz opened this issue Mar 30, 2015 · 4 comments
Closed

Detect “No preview available” when generating thumbs #56

andylolz opened this issue Mar 30, 2015 · 4 comments

Comments

@andylolz
Copy link
Collaborator

I wonder if phantom.js could spot “No preview available”, and avoid generating a thumbnail. This would potentially be really handy:

  1. Without a thumbnail, the document won’t be displayed in recent CVs / on the frontpage / in the og:image for the homepage / on @democlubCVs
  2. We could get the cron to email us that something’s broken
@frabcus
Copy link
Owner

frabcus commented Mar 30, 2015

I reckon it can just look for the text `No preview available

@frabcus
Copy link
Owner

frabcus commented Mar 30, 2015

@andylolz think I've fixed this! I've deployed to mpcv app. Do you have cron running from any other apps?

@andylolz
Copy link
Collaborator Author

nope

@andylolz
Copy link
Collaborator Author

This looks much nicer than my solution (filecmp.cmp() with a “No preview available” image in the repo!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants