Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consecutive passport numbering #29

Open
holocronweaver opened this issue Jan 29, 2015 · 2 comments
Open

Consecutive passport numbering #29

holocronweaver opened this issue Jan 29, 2015 · 2 comments
Assignees

Comments

@holocronweaver
Copy link
Contributor

Is it necessary that the passport sections be consecutively numbered? If so, this could cause some tedium when removing an early entry in a long list of passports and having to -1 most of the sections.

@frace
Copy link
Owner

frace commented Jan 30, 2015

That's a good point - and to be honest I didn't think about a scenario where one would remove an early passport entry ^^. So I can't give you an answer right off the bat. I'll check this during the next couple of days. However I thought about replacing the numbering with the service name instead (e.g. [passport "github"]) anyways, but wasn't quite convinced to go that route.

@frace
Copy link
Owner

frace commented Feb 4, 2015

I figured it isn't really an issue because the numbering is used as an identifier to avoid duplicates inside the configfile. While parsing the passports get enumerated anyways. What happens if a user would remove a passport is that the numbering on the selection dialog does not match the identifier inside the configfile anymore. But as I said that doesn't have any impact on the result. However it's not a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants