-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urlparse doesn't always give 'base url' #31
Comments
@tverlaan Thank you for your report!
I'm not quite sure if it'd be more elegant to find a solution by using |
That would be indeed the most simple solution. This would also make it possible to have different name/email for github.com:tverlaan and github.com:somethingelse. |
I've thought about it. I think pattern matching is the way to go. It will cover more usecases but still allow for string matching. |
@tverlaan Could you please give an example? |
Well, some domains have multiple TLDs. Instead of listing each TLD (with name and possibly something after the slash, like my name), I want to use a regular expression. Eg.
It's maybe not the best example, but you can imagine there are a lot more uses for this. |
Ok, I see. |
@frace - I see no pull requests have been approved in 18 months. If we submit a PR, can you review and incorporate? |
Allow me to bump this up. Not being able to make the most out of git-passport when using ssh is a bit sad, it'd be lovely to have it merged! |
In quite a few cases with my own repositories git-passport doesn't recognize the url correctly. This has to do with the use of urlparse. Some examples:
I can think of two alternatives for fixing this issue:
The first solution would also allow for automatic matching different usernames for different projects with the same base url (say github.com). I'm happy to issue a PR, but I wanted to discuss first.
The text was updated successfully, but these errors were encountered: