Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example task not working with fractal-tasks-core 0.14.0 #4

Closed
fstur opened this issue Jan 15, 2024 · 3 comments · Fixed by #5
Closed

Example task not working with fractal-tasks-core 0.14.0 #4

fstur opened this issue Jan 15, 2024 · 3 comments · Fixed by #5

Comments

@fstur
Copy link

fstur commented Jan 15, 2024

Some fractal-tasks-core functions that are imported in the example task 'thresholding_task.py' are no longer available in fractal-tasks-core 0.14.0:

from fractal_tasks_core.lib_ngff import load_NgffImageMeta
from fractal_tasks_core.lib_pyramid_creation import build_pyramid

@jluethi
Copy link
Collaborator

jluethi commented Jan 15, 2024

Thanks for reporting this, we should definitely update the template to 0.14.0!

Those 2 are now here:

from fractal_tasks_core.ngff import load_NgffImageMeta
from fractal_tasks_core.pyramids import build_pyramid

See here for others: fractal-analytics-platform/fractal-tasks-core#631 (comment)

I'll have a go at updating the template :)

@fstur
Copy link
Author

fstur commented Jan 15, 2024

Great, thanks!

@jluethi jluethi linked a pull request Jan 15, 2024 that will close this issue
@jluethi
Copy link
Collaborator

jluethi commented Jan 15, 2024

Ok, turns out it was just those 2 :)

As you can see, the actual example Fractal task is very barebones, we definitely want to add more. But we'll do so after an upcoming task API refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants