Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort helper should return default value #60

Open
emolayi opened this issue Oct 10, 2019 · 0 comments
Open

Sort helper should return default value #60

emolayi opened this issue Oct 10, 2019 · 0 comments

Comments

@emolayi
Copy link
Contributor

emolayi commented Oct 10, 2019

Using the following helper to set aria-sort on a column results in accessibility issues because no default value is provided: https://github.com/fractaledmind/actionset/blob/master/lib/action_set/helpers/sort/current_direction_for_helper.rb

On page load, when sort param is not set, this method should return none: https://www.w3.org/WAI/PF/aria/states_and_properties#aria-sort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emolayi