Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting can cause model's default scope to override #35

Open
emolayi opened this issue Jan 2, 2019 · 2 comments
Open

Sorting can cause model's default scope to override #35

emolayi opened this issue Jan 2, 2019 · 2 comments

Comments

@emolayi
Copy link

emolayi commented Jan 2, 2019

When merging in the sort instructions, the default scope on a model will override conflicting filters applied to the passed in set:
https://github.com/fractaledmind/activeset/blob/master/lib/active_set/sorting/active_record_strategy.rb#L15
@fractaledmind fractaledmind mentioned this issue Jan 18, 2019
Open
@fractaledmind
Copy link
Owner

Moved to new monorepo -> fractaledmind/actionset#25

@fractaledmind fractaledmind reopened this May 5, 2019
@fractaledmind
Copy link
Owner

@emolayi or @riyengar8: Can you write a spec to capture this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fractaledmind @emolayi