fix issues in list.[ch] #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix failing test. |
|
Looks okay in theory; can you please rewrite your commits to separate them into logically separate changes? ie. not just one commit named "fix issues"; one to add input validation, another to add the callback function. Please include meaningful descriptions; see here for suggestions: |
|
Sorry for this. git is not much familiar to me. I'll rewrite these again. |
|
No problem, I understand. "Remove this" was a reference to the terminating NULL in list_to_array(). This isn't necessary and I'd rather not add it. |
|
OK. I'll rewrite these again. Thank you for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some validation check of input parameters.
add a callback function to clean up ListValue when remove entries.