-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a new screen takes more time with FluidNavigator than with StackNavigator #44
Comments
Could it be that you are doing some work in |
@chrfalch If you check the Snack you'll see it's mostly the same code from |
And thats exactly the same we're doing in the example as well. Would it be possible to use the style parameter for the fluid navigator? You can see how this is done in the ShoeShop example: const Navigator = FluidNavigator({
screen1: { screen: Screen1 },
screen2: { screen: Screen2 },
}, {
style: { backgroundColor: '#C14534' },
navigationOptions: {
gesturesEnabled: true,
},
}); |
Not sure I'm following you exactly but I've just tried setting the background on the Snack and it doesn't seem to change anything. I've found a related closed issue which describes the same issue: #7 |
I'm not sure if the issue I'm seeing is a real issue ;-) Even the example app has a slight delay after clicking on the example buttons? |
The library works fantastically well in terms of the the actual transitions etc, but a two second delay before the |
Ok, in the Snack provided I get around 0,5 secs, is this on Android or iOS? |
It looks like it takes approx 0.5 secs? Same as I experienced running the Snack. |
If I change FluidNavigator to StackNavigator I see that the speed is much better. I'll take a look and see, always happy to try to optimize the library! |
Ok, well unfortunately that's still too long for our app. Thanks for your help anyway. If performance ever improves do let me know and we'll revisit the library. |
(See last comment) |
Thanks - it's truly a great library, am keen to use it if you manage to optimise this. |
@chrfalch any solution to this? Am also navigating to a fluidNavigator from a stack and getting a white flash. |
Although it seems the code execution seems to call |
Same issue here, no matter how i optimize my code. Any click wait about 0.5s animation start. The animation looks good, but why must wait 0.5s ??? |
In the example it looks like this is solved for the latest releases, could you check and see? @roytan883, @jskidd3, @Jonovono |
in the version 0.2.74 ,I don't think this problem has been solved |
in ImageListScreen.js ,I set image max size is 100 , click will wait about 1.5s animation start,but set image max size is 3 ,click is normal |
Could be related to the fact that when you use react-navigation, screens don't unmount when you navigate away from them, but stay mounted somehow in the background until you return to them. It doesn't seem like fluid-transitions does that optimization. |
Is there any update about the performance of the waiting time before the transition starts? This library is very helpful with very interesting transitions that we can implement in our production app. |
@jskidd3 did you find any solution for this? |
I am experiencing a white screen which shows for roughly 2 seconds when navigating to a
FluidNavigator
from another screen embedded inside aStackNavigator
.If this is the incorrect way to use the library, please could you explain how I can change the code in the Snack below so that it functions without the white screen?
https://snack.expo.io/B1ZDrVbZ7
The text was updated successfully, but these errors were encountered: