Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] React 18 issues #1421

Closed
marcospassos opened this issue Jan 14, 2022 · 7 comments
Closed

[BUG] React 18 issues #1421

marcospassos opened this issue Jan 14, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@marcospassos
Copy link

Using React 18 a component inside <AnimatePresence/> does not unmount from the DOM after the exit animation finishes. There are also other issues involving layoutId, but the one that seems really broken is the <AnimatePresence/>.

It seems that most issues are related to the strict mode. Disabling it fix the issue.

Framer version: 5.5.5
React version: 18.0.0-rc0

@marcospassos marcospassos added the bug Something isn't working label Jan 14, 2022
@mattgperry
Copy link
Collaborator

Thanks for the report! With layoutId, are the other issues specifically in relation to AnimatePresence?

@marcospassos
Copy link
Author

All issues I've noticed are related to <AnimatedPresence/>. Even disabling the strict mode, animations that are not directly child of the <AnimatedPresence/> don't work.

@mattgperry
Copy link
Collaborator

Ah yeah that makes sense it still isn't concurrent safe, we'll have to take a look at this soon.

@vpontis
Copy link

vpontis commented Feb 5, 2022

Ah yeah that makes sense it still isn't concurrent safe, we'll have to take a look at this soon.

That would be awesome, thanks @mattgperry. This is blocking our upgrade to React 18 and we love Framer Motion :)

@JarolinVargas
Copy link

Any updates on this? I'm also dealing with this issue

@madebyfabian
Copy link

Also facing this issue when upgrading to react 18. Since this is Open for such a long time, what can we do to get more focus on fixing things for react 18? I can provide a reproduction codesandbox if that helps. But it's also stopping me from upgrading to react 18, therefore it would be great to see at least a workaround for this.

@mattgperry
Copy link
Collaborator

mattgperry commented Jan 4, 2023

We've been on 18 for a while so please make new tickets with Sandbox examples of any issues you run into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants