Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.12.8 is a breaking change for older browsers #2110

Closed
cevr opened this issue May 5, 2023 · 3 comments
Closed

10.12.8 is a breaking change for older browsers #2110

cevr opened this issue May 5, 2023 · 3 comments

Comments

@cevr
Copy link

cevr commented May 5, 2023

Not sure where to put this, up until this patch, framer-motion has worked for at least chrome 56 (stuck in this version to support Samsung's Tizen OS systems).

Not any longer with queueMicrotask upgrade. Wasn't sure if this was a priority, but figured I would let you know

@mattdeco
Copy link

mattdeco commented May 8, 2023

Additionally, I'm seeing regressions across multiple apps when upgrading to 10.12.8. It seems the change is breaking a variety of animations that use the layout prop and / or the <AnimatePresence> component. Downgrading and pinning to 10.12.7 resolves the issues.

It seems that animations instantly transition under certain conditions on 10.12.8.

@sandren
Copy link

sandren commented May 16, 2023

All of the new issues being opened related to layout animations are caused by this change as well.

@mattgperry
Copy link
Collaborator

Thanks for the heads-up, these aren't supported browsers for us (<2%) but as I go through these tickets I'll take a look at things that might have been affected by queueMicrotasks. The nice thing about this is it batches animations but in a synchronous way, therefore if we get a double render via useLayoutEffect (which is quite common) we can cut a substantial amount of layout animations. So I would prefer to keep it, but will pay attention to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants